Skip to content

deps: V8: cherry-pick f93055fbd5aa #60105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

deps: V8: cherry-pick f93055fbd5aa #60105

wants to merge 1 commit into from
+32 −1

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Oct 2, 2025 •
edited
Loading

Original commit message:

[runtime] Fastcase for empty getOwnPropertySymbols()

Since symbols are not enumerable we can rule them out in case all
properties are in the enum cache.

Bug: 447154198
Change-Id: Ib2d58b67e5058d98323fcebaef3daba88c6304b5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6983286
Commit-Queue: Olivier Flückiger <[email protected]>
Reviewed-by: Toon Verwaest <[email protected]>
Auto-Submit: Olivier Flückiger <[email protected]>
Cr-Commit-Position: refs/heads/main@{#102878}

Refs: v8/v8@f93055f

This makes util.inspect and util.isDeepStrictEqual (including all APIs that are based on the same) significantly faster in case the objects do not contain any symbols (and are fast objects).

@o- @BridgeAR
deps: V8: cherry-pick f93055fbd5aa
36bac6b 
Original commit message:

    [runtime] Fastcase for empty getOwnPropertySymbols()

    Since symbols are not enumerable we can rule them out in case all
    properties are in the enum cache.

    Bug: 447154198
    Change-Id: Ib2d58b67e5058d98323fcebaef3daba88c6304b5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6983286
    Commit-Queue: Olivier Flückiger <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Auto-Submit: Olivier Flückiger <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#102878}

Refs: v8/v8@f93055f
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 2, 2025
@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69505/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6782/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6782/

@nodejs-github-bot
Copy link
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6782/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69536/

gurgunday
gurgunday approved these changes Oct 4, 2025
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

targos pushed a commit that referenced this pull request Oct 6, 2025
@o- @targos
deps: V8: cherry-pick f93055fbd5aa
3db2f58 
Original commit message:

    [runtime] Fastcase for empty getOwnPropertySymbols()

    Since symbols are not enumerable we can rule them out in case all
    properties are in the enum cache.

    Bug: 447154198
    Change-Id: Ib2d58b67e5058d98323fcebaef3daba88c6304b5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6983286
    Commit-Queue: Olivier Flückiger <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Auto-Submit: Olivier Flückiger <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#102878}

Refs: v8/v8@f93055f
PR-URL: #60105
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@targos
Copy link
Member

targos commented Oct 6, 2025

Landed in 3db2f58

@targos targos closed this Oct 6, 2025
targos pushed a commit that referenced this pull request Oct 6, 2025
@o- @targos
deps: V8: cherry-pick f93055fbd5aa
04d568e 
Original commit message:

    [runtime] Fastcase for empty getOwnPropertySymbols()

    Since symbols are not enumerable we can rule them out in case all
    properties are in the enum cache.

    Bug: 447154198
    Change-Id: Ib2d58b67e5058d98323fcebaef3daba88c6304b5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6983286
    Commit-Queue: Olivier Flückiger <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Auto-Submit: Olivier Flückiger <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#102878}

Refs: v8/v8@f93055f
PR-URL: #60105
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Merged
targos pushed a commit to targos/node that referenced this pull request Oct 7, 2025
@o- @targos
deps: V8: cherry-pick f93055fbd5aa
8d954c3 
Original commit message:

    [runtime] Fastcase for empty getOwnPropertySymbols()

    Since symbols are not enumerable we can rule them out in case all
    properties are in the enum cache.

    Bug: 447154198
    Change-Id: Ib2d58b67e5058d98323fcebaef3daba88c6304b5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6983286
    Commit-Queue: Olivier Flückiger <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Auto-Submit: Olivier Flückiger <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#102878}

Refs: v8/v8@f93055f
PR-URL: nodejs#60105
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Oct 12, 2025
@o- @targos
deps: V8: cherry-pick f93055fbd5aa
0f64680 
Original commit message:

    [runtime] Fastcase for empty getOwnPropertySymbols()

    Since symbols are not enumerable we can rule them out in case all
    properties are in the enum cache.

    Bug: 447154198
    Change-Id: Ib2d58b67e5058d98323fcebaef3daba88c6304b5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6983286
    Commit-Queue: Olivier Flückiger <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Auto-Submit: Olivier Flückiger <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#102878}

Refs: v8/v8@f93055f
PR-URL: nodejs#60105
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Oct 20, 2025
@o- @targos
deps: V8: cherry-pick f93055fbd5aa
a4b4ac3 
Original commit message:

    [runtime] Fastcase for empty getOwnPropertySymbols()

    Since symbols are not enumerable we can rule them out in case all
    properties are in the enum cache.

    Bug: 447154198
    Change-Id: Ib2d58b67e5058d98323fcebaef3daba88c6304b5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6983286
    Commit-Queue: Olivier Flückiger <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Auto-Submit: Olivier Flückiger <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#102878}

Refs: v8/v8@f93055f
PR-URL: nodejs#60105
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
targos pushed a commit that referenced this pull request Oct 23, 2025
@o- @targos
deps: V8: cherry-pick f93055fbd5aa
de8386d 
Original commit message:

    [runtime] Fastcase for empty getOwnPropertySymbols()

    Since symbols are not enumerable we can rule them out in case all
    properties are in the enum cache.

    Bug: 447154198
    Change-Id: Ib2d58b67e5058d98323fcebaef3daba88c6304b5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6983286
    Commit-Queue: Olivier Flückiger <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Auto-Submit: Olivier Flückiger <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#102878}

Refs: v8/v8@f93055f
PR-URL: #60105
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Oct 25, 2025
@o- @targos
deps: V8: cherry-pick f93055fbd5aa
e808aa0 
Original commit message:

    [runtime] Fastcase for empty getOwnPropertySymbols()

    Since symbols are not enumerable we can rule them out in case all
    properties are in the enum cache.

    Bug: 447154198
    Change-Id: Ib2d58b67e5058d98323fcebaef3daba88c6304b5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6983286
    Commit-Queue: Olivier Flückiger <[email protected]>
    Reviewed-by: Toon Verwaest <[email protected]>
    Auto-Submit: Olivier Flückiger <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#102878}

Refs: v8/v8@f93055f
PR-URL: nodejs#60105
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95 aduh95 added the backported-to-v25.x PRs backported to the v25.x-staging branch. label Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@legendecas legendecas legendecas approved these changes

+1 more reviewer

@gurgunday gurgunday gurgunday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v25.x PRs backported to the v25.x-staging branch. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@BridgeAR @nodejs-github-bot @targos @cjihrig @legendecas @gurgunday @aduh95 @o-